rename packageValidation to package testing #7375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rename looks fine. Are we considering adding this feature to the SDK package? Do we think it's interesting for people to be able to generate projects that consume their package? |
ericstj
approved these changes
May 11, 2021
safern
approved these changes
May 11, 2021
It will probably fall with the package dependency stuff as we require dependencies to verify the closure.
We can probably avoid that if we are able to get the assembly dependencies by some easier method. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to not put package validation into the arcade and we will not be puting the packagetesting stuff into it. So just renaming the package here.